refactor(@angular/cli): re-add resolveModule for find examples tool#33129
Merged
clydin merged 1 commit intoangular:21.2.xfrom May 5, 2026
Merged
refactor(@angular/cli): re-add resolveModule for find examples tool#33129clydin merged 1 commit intoangular:21.2.xfrom
clydin merged 1 commit intoangular:21.2.xfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a resolveModule method to the Host interface and provides an implementation in LocalWorkspaceHost using Node's createRequire. Review feedback identifies a security risk where createRootRestrictedHost could bypass root restrictions if not updated, and suggests a correction to resolveModule to ensure it handles directory paths correctly. Additionally, MockHost requires an implementation to maintain test compatibility.
clydin
force-pushed
the
readd-resolve-module-host
branch
from
dbcb1b0 to
923326c
Compare
alan-agius4
approved these changes
May 5, 2026
Member
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.